Hard-coded language strings in Post Locator Plug-In

[d9media]

At row 66 of gmw_search_form_post_types method in GMW_PT_Search_Form_Helper (located in wp-content/plugins/geo-my-wp/plugins/posts-locator/includes/gmw-posts-locator-search-form-template-functions.php) there are multiple instances of hard-coded strings.

$options_all = 'All ' . esc_html( $taxonomy->labels->name ); $placeholder = 'Select ' . esc_html( $taxonomy->labels->name );

1 2	$options_all = 'All ' . esc_html( $taxonomy->labels->name ); $placeholder = 'Select ' . esc_html( $taxonomy->labels->name );

Since these are wrapped within a class and no filters are being used, it is impossible to alter these easily in an update-safe manner. Therefore I propose the following changes:

$options_all = __( 'All', 'geo-my-wp' ) . ' ' . esc_html( $taxonomy->labels->name ); $placeholder =__( 'Select' ) . ' ' . esc_html( $taxonomy->labels->name );

1 2	$options_all = __( 'All', 'geo-my-wp' ) . ' ' . esc_html( $taxonomy->labels->name ); $placeholder =__( 'Select' ) . ' ' . esc_html( $taxonomy->labels->name );

“All” is already translated in GeoWP so that will work right away. Select has to be added to a translation file or a WP namespace may be used:

#: wp-includes/media.php:3638 wp-includes/js/dist/edit-post.js:728 msgid "Select" msgstr "Auswählen"

1 2 3

#: wp-includes/media.php:3638 wp-includes/js/dist/edit-post.js:728 msgid "Select" msgstr "Auswählen"

(see line 15480 of wordpress POT file)

Please consider patching this for the next release.

[Eyal Fitoussi]

Hello @d9media,

Thank you for pointing this out. I will make those strings translatable in the next version of the plugin.

However, there is actually a filter that you can use for modifying those strings. The filter is in line 73 of that same file ( ‘gmw_search_form_’ . $args[‘usage’] . ‘_taxonomy_args’ ).

I hope this helps.

[Author]

Posts